[GitHub] [iceberg] Fokko merged pull request #6447: Rename jmh-bechmarks.yml to jmh-benchmarks.yml

Fokko merged PR #6447: URL: https://github.com/apache/iceberg/pull/6447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051651449 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051655803 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051656395 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051656611 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051656685 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051657208 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051657435 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeClient.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051657795 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] rdblue closed issue #6434: PyIceberg support for UUID types

rdblue closed issue #6434: PyIceberg support for UUID types URL: https://github.com/apache/iceberg/issues/6434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [iceberg] rdblue commented on pull request #6446: Python: Support for UUID

rdblue commented on PR #6446: URL: https://github.com/apache/iceberg/pull/6446#issuecomment-1356866645 Thanks, @Fokko! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [iceberg] rdblue merged pull request #6446: Python: Support for UUID

rdblue merged PR #6446: URL: https://github.com/apache/iceberg/pull/6446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue commented on pull request #6438: Python: Reduce the use of mock objects

rdblue commented on PR #6438: URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1356866813 Looks like this needs to be rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [iceberg] rdblue commented on a diff in pull request #6436: Core: Add flag to control sending metric reports via REST

rdblue commented on code in PR #6436: URL: https://github.com/apache/iceberg/pull/6436#discussion_r1051658603 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -316,14 +324,18 @@ private void reportMetrics( TableIdentifier tableIdentifier,

[GitHub] [iceberg] rdblue commented on pull request #6436: Core: Add flag to control sending metric reports via REST

rdblue commented on PR #6436: URL: https://github.com/apache/iceberg/pull/6436#issuecomment-1356867159 Looks like this also adds support for the metrics-impl property. Does this replace the other PR? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051658860 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051658893 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +756,61 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) -

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051659755 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051659883 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660133 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660133 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660281 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] Fokko commented on pull request #6438: Python: Reduce the use of mock objects

Fokko commented on PR #6438: URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1356869306 @rdblue rebased! 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660578 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660578 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660648 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660757 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051660823 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051660857 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661024 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661123 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661231 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661302 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661329 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661360 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661412 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661468 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661637 ## python/tests/io/test_pyarrow.py: ## @@ -572,3 +581,388 @@ def test_always_true_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_always_false_to_

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661689 ## python/pyproject.toml: ## @@ -222,5 +222,9 @@ ignore_missing_imports = true module = "pyparsing.*" ignore_missing_imports = true +[[tool.mypy.overrides]] +module

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051661784 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051661822 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051662280 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeTableOperations.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051662251 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeTableOperations.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] MohamedAdelHsn opened a new issue, #6448: Can not read data loaded to hive from kafka via flink sql with iceberg format

MohamedAdelHsn opened a new issue, #6448: URL: https://github.com/apache/iceberg/issues/6448 ### Query engine Flink Sql ### Question i am doing project using flink sql to streaming data from kafka to hive tables with iceberg format . i working several days in this iss

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051662809 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051662857 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051663154 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051673608 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051673764 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051674356 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051674469 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051674613 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051674859 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051675125 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051675416 ## python/pyiceberg/io/pyarrow.py: ## @@ -44,8 +49,14 @@ S3FileSystem, ) -from pyiceberg.expressions import BooleanExpression, BoundTerm, Literal -from pyiceberg

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051676210 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +459,120 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6437: Python: Projection by Field ID

rdblue commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1051676372 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarro

[GitHub] [iceberg] rdblue commented on a diff in pull request #6433: Docs: README

rdblue commented on code in PR #6433: URL: https://github.com/apache/iceberg/pull/6433#discussion_r1051676679 ## README.md: ## @@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation. The core Java library that tracks table snapshots and metad

[GitHub] [iceberg] rdblue merged pull request #6438: Python: Reduce the use of mock objects

rdblue merged PR #6438: URL: https://github.com/apache/iceberg/pull/6438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue commented on a diff in pull request #6432: Consider moving to ParallelIterable in Deletes::toPositionIndex

rdblue commented on code in PR #6432: URL: https://github.com/apache/iceberg/pull/6432#discussion_r1051677178 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -144,7 +146,18 @@ public static PositionDeleteIndex toPositionIndex( deletes ->

[GitHub] [iceberg] rdblue commented on pull request #6432: Consider moving to ParallelIterable in Deletes::toPositionIndex

rdblue commented on PR #6432: URL: https://github.com/apache/iceberg/pull/6432#issuecomment-1356891084 I think this looks good. I like how small the change is. Do you think it would be easy to also add a config flag to enable/disable this? I think it technically violates Spark's threading m

[GitHub] [iceberg] rdblue commented on a diff in pull request #6431: Parquet: Fix ParquetDictionaryRowGroupFilter evaluating NaN.

rdblue commented on code in PR #6431: URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051678034 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java: ## @@ -165,20 +165,41 @@ public Boolean isNaN(BoundReference ref) { }

[GitHub] [iceberg] rdblue commented on a diff in pull request #6431: Parquet: Fix ParquetDictionaryRowGroupFilter evaluating NaN.

rdblue commented on code in PR #6431: URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051678076 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java: ## @@ -165,20 +165,41 @@ public Boolean isNaN(BoundReference ref) { }

[GitHub] [iceberg] srilman commented on issue #3220: [Python] support iceberg hadoop catalog in python library

srilman commented on issue #3220: URL: https://github.com/apache/iceberg/issues/3220#issuecomment-1356891779 @Fokko Didn't realize that there was a Docker image for REST catalog! We use a very similar Docker Compose setup to test for Hive catalog support, which is great for testing catalog

[GitHub] [iceberg] rdblue commented on a diff in pull request #6431: Parquet: Fix ParquetDictionaryRowGroupFilter evaluating NaN.

rdblue commented on code in PR #6431: URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051678197 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -360,6 +362,21 @@ public void testNotNaNs() { Assert.assertTrue("Should

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051678623 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051679094 ## build.gradle: ## @@ -696,6 +696,26 @@ project(':iceberg-dell') { } } +project(':iceberg-snowflake') { + test { +useJUnitPlatform() + } + + dependencies {

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051679653 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051679710 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051679882 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051680116 ## snowflake/src/main/java/org/apache/iceberg/snowflake/NamespaceHelpers.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051680606 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeTableMetadata.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051680729 ## snowflake/src/test/java/org/apache/iceberg/snowflake/InMemoryFileIO.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [iceberg] rbalamohan commented on a diff in pull request #6432: Consider moving to ParallelIterable in Deletes::toPositionIndex

rbalamohan commented on code in PR #6432: URL: https://github.com/apache/iceberg/pull/6432#discussion_r1051680991 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -144,7 +146,18 @@ public static PositionDeleteIndex toPositionIndex( deletes ->

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681027 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeIdentifier.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681274 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681423 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681587 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681776 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681930 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeClient.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051681975 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeClient.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051682219 ## spark/v3.1/build.gradle: ## @@ -213,6 +213,9 @@ project(':iceberg-spark:iceberg-spark-runtime-3.1_2.12') { implementation(project(':iceberg-nessie')) { ex

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051682372 ## versions.props: ## @@ -28,6 +28,8 @@ org.scala-lang.modules:scala-collection-compat_2.12 = 2.6.0 org.scala-lang.modules:scala-collection-compat_2.13 = 2.6.0 com.emc

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051682458 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051682638 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeTableOperations.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] rdblue commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

rdblue commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051682764 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeTableOperations.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] rdblue commented on a diff in pull request #6411: Core: Don't produce partition summaries on unpartitioned table

rdblue commented on code in PR #6411: URL: https://github.com/apache/iceberg/pull/6411#discussion_r1051683043 ## spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java: ## @@ -898,7 +898,7 @@ public void testSnapshotsTable() {

[GitHub] [iceberg] rdblue commented on a diff in pull request #6411: Core: Don't produce partition summaries on unpartitioned table

rdblue commented on code in PR #6411: URL: https://github.com/apache/iceberg/pull/6411#discussion_r1051683205 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -896,17 +896,14 @@ public void testAddDeleteFilesMultipleSpecs() { Map summary = snapshot.summary(

[GitHub] [iceberg] rdblue commented on a diff in pull request #6411: Core: Don't produce partition summaries on unpartitioned table

rdblue commented on code in PR #6411: URL: https://github.com/apache/iceberg/pull/6411#discussion_r1051683043 ## spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java: ## @@ -898,7 +898,7 @@ public void testSnapshotsTable() {

[GitHub] [iceberg] rdblue commented on pull request #6426: Flink: add fixed field type for DataGenerators test util

rdblue commented on PR #6426: URL: https://github.com/apache/iceberg/pull/6426#issuecomment-1356899972 Looks reasonable to me, but I don't have context on the rest of the discussion. Feel free to merge when you both are happy with this, @pvary and @stevenzwu. -- This is an automated mess

[GitHub] [iceberg] rdblue commented on a diff in pull request #6417: Reuse existing parquet reader in ReadConf (6416)

rdblue commented on code in PR #6417: URL: https://github.com/apache/iceberg/pull/6417#discussion_r1051684313 ## parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java: ## @@ -185,21 +184,16 @@ private Map generateOffsetToStartPos(Schema schema) { return null;

[GitHub] [iceberg] rdblue commented on a diff in pull request #6432: Consider moving to ParallelIterable in Deletes::toPositionIndex

rdblue commented on code in PR #6432: URL: https://github.com/apache/iceberg/pull/6432#discussion_r1051684443 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -144,7 +146,18 @@ public static PositionDeleteIndex toPositionIndex( deletes ->

[GitHub] [iceberg] rdblue merged pull request #6404: Core: Allow configuring metrics reporter impl via Catalog property

rdblue merged PR #6404: URL: https://github.com/apache/iceberg/pull/6404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue commented on pull request #6404: Core: Allow configuring metrics reporter impl via Catalog property

rdblue commented on PR #6404: URL: https://github.com/apache/iceberg/pull/6404#issuecomment-1356901600 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [iceberg] rdblue commented on a diff in pull request #6401: Flink: Change to oldestAncestorAfter

rdblue commented on code in PR #6401: URL: https://github.com/apache/iceberg/pull/6401#discussion_r1051685128 ## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/ContinuousSplitPlannerImpl.java: ## @@ -213,17 +213,12 @@ static Optional startSnapshot(Tab

[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

rdblue commented on code in PR #6379: URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685727 ## docs/hive.md: ## @@ -38,6 +38,16 @@ Iceberg compatibility with Hive 2.x and Hive 3.1.2/3 supports the following feat DML operations work only with MapReduce executi

[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

rdblue commented on code in PR #6379: URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685815 ## docs/hive.md: ## @@ -244,7 +254,7 @@ The result is: | j | IDENTITY | NULL You can create Iceberg partitions using the follo

[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

rdblue commented on code in PR #6379: URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685890 ## docs/hive.md: ## @@ -433,6 +449,15 @@ Tables can be dropped using the `DROP TABLE` command: DROP TABLE [IF EXISTS] table_name [PURGE]; ``` +### METADATA LOCATION

[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

rdblue commented on code in PR #6379: URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685991 ## docs/hive.md: ## @@ -509,7 +534,15 @@ SELECT * FROM table_a FOR SYSTEM_TIME AS OF '2021-08-09 10:35:57'; SELECT * FROM table_a FOR SYSTEM_VERSION AS OF 1234567; ``

[GitHub] [iceberg] rdblue commented on pull request #6392: Python: Add adlfs support (Azure DataLake FileSystem)

rdblue commented on PR #6392: URL: https://github.com/apache/iceberg/pull/6392#issuecomment-1356903295 @cccs-eric, looks like this was out of date. I tried to fix conflicts, but it is failing tests. Can you fix and then we'll merge? -- This is an automated message from the Apache Git Serv

  1   2   >