[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051360946 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] Fokko commented on a diff in pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

2022-12-17 Thread GitBox
Fokko commented on code in PR #6445: URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051363319 ## python/tests/cli/test_console.py: ## @@ -134,14 +134,17 @@ def update_namespace_properties( MOCK_ENVIRONMENT = {"PYICEBERG_CATALOG__PRODUCTION__URI": "test://doesnot

[GitHub] [iceberg] Fokko merged pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

2022-12-17 Thread GitBox
Fokko merged PR #6445: URL: https://github.com/apache/iceberg/pull/6445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051368174 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java: ## @@ -295,6 +299,161 @@ private static void assertEquals( } } + public stati

[GitHub] [iceberg] pvary commented on issue #6370: What is the purpose of Hive Lock ?

2022-12-17 Thread GitBox
pvary commented on issue #6370: URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1356124377 Maybe something like this: ``` diff --git a/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift b/standalone-metastore/metastore-common/src/main/thrift/hi

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051380948 ## core/src/main/java/org/apache/iceberg/BaseFilesTable.java: ## @@ -223,34 +225,28 @@ ManifestFile manifest() { static class ContentFileStructWithMetrics implemen

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051382070 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051382070 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051382070 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6222: Flink: Support inspecting table

2022-12-17 Thread GitBox
hililiwei commented on code in PR #6222: URL: https://github.com/apache/iceberg/pull/6222#discussion_r1051383730 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] blcksrx commented on pull request #4465: Add FileIO implementation for Azure Blob Storage

2022-12-17 Thread GitBox
blcksrx commented on PR #4465: URL: https://github.com/apache/iceberg/pull/4465#issuecomment-1356227315 Any plan to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [iceberg-docs] InvisibleProgrammer opened a new pull request, #191: Fix sidebar

2022-12-17 Thread GitBox
InvisibleProgrammer opened a new pull request, #191: URL: https://github.com/apache/iceberg-docs/pull/191 Reason and sample screenshots: https://github.com/apache/iceberg/issues/6381 This provides a fix for an issue in that the sidebar menu completely disappears from the documentation

[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

2022-12-17 Thread GitBox
InvisibleProgrammer commented on PR #6379: URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1356327476 Hey there! With the help of @pvary , all updates for the older releases are merged. I wonder, do you know what is the process of releasing the merged changes?

[GitHub] [iceberg] maximethebault commented on issue #6224: Spark: regression / query failure with Iceberg 1.0.0 and UNION

2022-12-17 Thread GitBox
maximethebault commented on issue #6224: URL: https://github.com/apache/iceberg/issues/6224#issuecomment-1356353314 Thanks for investigating this issue further! I'll go ahead and close this issue since it isn't Iceberg-related. I'll make sure to keep an eye on the Spark issue you created.

[GitHub] [iceberg] maximethebault closed issue #6224: Spark: regression / query failure with Iceberg 1.0.0 and UNION

2022-12-17 Thread GitBox
maximethebault closed issue #6224: Spark: regression / query failure with Iceberg 1.0.0 and UNION URL: https://github.com/apache/iceberg/issues/6224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [iceberg] dennishuo commented on pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

2022-12-17 Thread GitBox
dennishuo commented on PR #6428: URL: https://github.com/apache/iceberg/pull/6428#issuecomment-1356445009 Interesting, not sure why it removed @danielcweeks when I re-requested review from @nastra (definitely wasn't intentional -- as far as I can tell my repository permissions don't even pr

[GitHub] [iceberg] github-actions[bot] commented on issue #5086: Add a connector for Python Flink DataStream API

2022-12-17 Thread GitBox
github-actions[bot] commented on issue #5086: URL: https://github.com/apache/iceberg/issues/5086#issuecomment-1356511133 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

[GitHub] [iceberg] github-actions[bot] commented on issue #4971: new snapshot file(../metadata/snap-xxx.avro) will be generated as checkpoint commit, even though there is no data from cdc

2022-12-17 Thread GitBox
github-actions[bot] commented on issue #4971: URL: https://github.com/apache/iceberg/issues/4971#issuecomment-1356511150 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #3024: Arrow: Convert dict encoded vectors to their expected Arrow vector types

2022-12-17 Thread GitBox
amogh-jahagirdar commented on code in PR #3024: URL: https://github.com/apache/iceberg/pull/3024#discussion_r1051508734 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ArrowVectorAccessors.java: ## @@ -31,7 +33,7 @@ final class ArrowVectorAccessors { static {

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #3024: Arrow: Convert dict encoded vectors to their expected Arrow vector types

2022-12-17 Thread GitBox
amogh-jahagirdar commented on code in PR #3024: URL: https://github.com/apache/iceberg/pull/3024#discussion_r1051508734 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ArrowVectorAccessors.java: ## @@ -31,7 +33,7 @@ final class ArrowVectorAccessors { static {

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #3024: Arrow: Convert dict encoded vectors to their expected Arrow vector types

2022-12-17 Thread GitBox
amogh-jahagirdar commented on code in PR #3024: URL: https://github.com/apache/iceberg/pull/3024#discussion_r1051509275 ## arrow/src/main/java/org/apache/iceberg/arrow/DictEncodedArrowConverter.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #3024: Arrow: Convert dict encoded vectors to their expected Arrow vector types

2022-12-17 Thread GitBox
amogh-jahagirdar commented on code in PR #3024: URL: https://github.com/apache/iceberg/pull/3024#discussion_r1051509275 ## arrow/src/main/java/org/apache/iceberg/arrow/DictEncodedArrowConverter.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u