Re: [PR] test: add FileIO s3 test [iceberg-rust]

2024-02-26 Thread via GitHub
Fokko commented on PR #220: URL: https://github.com/apache/iceberg-rust/pull/220#issuecomment-1965933411 Thanks @odysa for working on this! Great to have this in, thanks @liurenjie1024 for the review 👍 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] test: add FileIO s3 test [iceberg-rust]

2024-02-26 Thread via GitHub
Fokko merged PR #220: URL: https://github.com/apache/iceberg-rust/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] test: add FileIO s3 test [iceberg-rust]

2024-02-25 Thread via GitHub
liurenjie1024 commented on code in PR #220: URL: https://github.com/apache/iceberg-rust/pull/220#discussion_r1502118268 ## crates/iceberg/Cargo.toml: ## @@ -62,6 +62,8 @@ urlencoding = { workspace = true } uuid = { workspace = true } [dev-dependencies] +iceberg_test_utils =

Re: [PR] test: add FileIO s3 test [iceberg-rust]

2024-02-25 Thread via GitHub
liurenjie1024 commented on code in PR #220: URL: https://github.com/apache/iceberg-rust/pull/220#discussion_r1502116767 ## crates/iceberg/testdata/file_io_s3/docker-compose.yaml: ## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib