Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-04-05 Thread via GitHub
redpheonixx commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r2001293953 ## tests/io/test_pyarrow_stats.py: ## @@ -72,7 +72,7 @@ StringType, ) from pyiceberg.utils.datetime import date_to_days, datetime_to_micros, time_to_

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-04-05 Thread via GitHub
redpheonixx commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r2001294212 ## tests/io/test_pyarrow_stats.py: ## @@ -470,6 +473,9 @@ def construct_test_table_primitive_types() -> Tuple[pq.FileMetaData, Union[Table strings = ["

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-24 Thread via GitHub
redpheonixx closed pull request #1799: handle decimal physicial type mapping URL: https://github.com/apache/iceberg-python/pull/1799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-18 Thread via GitHub
redpheonixx commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r2001295701 ## tests/io/test_pyarrow_stats.py: ## @@ -529,8 +538,12 @@ def test_metrics_primitive_types() -> None: assert datafile.lower_bounds[10] == b"he" as

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-18 Thread via GitHub
redpheonixx commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r2001296080 ## pyiceberg/io/pyarrow.py: ## @@ -2335,9 +2340,18 @@ def data_file_statistics_from_parquet_metadata( col_aggs[field_id] = StatsAggr

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-18 Thread via GitHub
Fokko commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r2000526902 ## pyiceberg/io/pyarrow.py: ## @@ -2335,9 +2340,18 @@ def data_file_statistics_from_parquet_metadata( col_aggs[field_id] = StatsAggregator

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r1999324401 ## tests/io/test_pyarrow_stats.py: ## @@ -72,7 +72,7 @@ StringType, ) from pyiceberg.utils.datetime import date_to_days, datetime_to_micros, time_to_m