Fokko commented on PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2598615303
@rodrigc Ah, I misread the comment. Let's remove it for now then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Fokko merged PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
rodrigc commented on PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2598397023
@Fokko I dont see any way around this other than removing this check. #1530
is blocked on this and @pawamoy suggested doing this:
https://github.com/apache/iceberg-python/pull/153
Fokko commented on PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597620177
@rodrigc Appreciate the work, thanks for taking the time! Can I suggested
instead of removing the check, should we replace it with one that you suggested?
--
This is an automated m
rodrigc commented on PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597351391
In the discussion of
https://github.com/pre-commit/pre-commit-hooks/issues/159 , Several other
projects chose to remove this check such as:
https://github.com/DanielNoord/j
rodrigc commented on PR #1531:
URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597352132
This is needed for this PR:
https://github.com/apache/iceberg-python/pull/1530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
