liurenjie1024 merged PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
marvinlanhenke commented on code in PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1621824738
##
crates/iceberg/src/spec/values.rs:
##
@@ -713,8 +866,117 @@ impl Datum {
}
}
+/// Map is a collection of key-value pairs with a key type and a valu
liurenjie1024 commented on code in PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1621647274
##
crates/iceberg/src/spec/datatypes.rs:
##
@@ -118,6 +118,15 @@ impl Type {
matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_))
}
+
ZENOTME commented on code in PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1620852535
##
crates/iceberg/src/spec/datatypes.rs:
##
@@ -118,6 +118,15 @@ impl Type {
matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_))
}
+//
liurenjie1024 commented on code in PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1620764612
##
crates/iceberg/src/spec/datatypes.rs:
##
@@ -118,6 +118,15 @@ impl Type {
matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_))
}
+
ZENOTME commented on PR #386:
URL: https://github.com/apache/iceberg-rust/pull/386#issuecomment-2137737297
cc @liurenjie1024 @Xuanwo @Fokko @marvinlanhenke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
