Re: [PR] fix: chrono dep [iceberg-rust]

2024-03-29 Thread via GitHub
liurenjie1024 merged PR #274: URL: https://github.com/apache/iceberg-rust/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] fix: chrono dep [iceberg-rust]

2024-03-29 Thread via GitHub
liurenjie1024 commented on PR #274: URL: https://github.com/apache/iceberg-rust/pull/274#issuecomment-2026824492 > > I think this could be solved by `cargo update`? > > > > This is required to make sure our users depends on `>= 0.4.34` since old versions don't have this new ty

Re: [PR] fix: chrono dep [iceberg-rust]

2024-03-29 Thread via GitHub
Xuanwo commented on PR #274: URL: https://github.com/apache/iceberg-rust/pull/274#issuecomment-2026814405 > I think this could be solved by `cargo update`? This is required to make sure our users depends on `>= 0.4.34` since old versions don't have this new type. -- This is an auto

Re: [PR] fix: chrono dep [iceberg-rust]

2024-03-29 Thread via GitHub
liurenjie1024 commented on PR #274: URL: https://github.com/apache/iceberg-rust/pull/274#issuecomment-2026807571 cc @odysa Should we close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] fix: chrono dep [iceberg-rust]

2024-03-18 Thread via GitHub
liurenjie1024 commented on PR #274: URL: https://github.com/apache/iceberg-rust/pull/274#issuecomment-2005699197 Hi, @odysa Thanks for this pr. I think this could be solved by `cargo update`? As a library, it's usually not good practice to fix it to a minor version. -- This is an automat