Re: [PR] feat: transform function [iceberg-cpp]

Xuanwo merged PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#issuecomment-2800283294 @Fokko @Xuanwo Could you help review and merge this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2040668421 ## src/iceberg/transform.h: ## @@ -56,16 +57,133 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +ICEBERG_EXPORT constexpr std:

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2040480756 ## src/iceberg/transform.cc: ## @@ -21,65 +21,113 @@ #include +#include "iceberg/transform_function.h" +#include "iceberg/type.h" + namespace iceberg { -namespa

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2039748800 ## src/iceberg/transform.cc: ## @@ -21,65 +21,113 @@ #include +#include "iceberg/transform_function.h" +#include "iceberg/type.h" + namespace iceberg { -namespa

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2038699818 ## src/iceberg/transform.h: ## @@ -56,16 +57,98 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +constexpr std::string_view T

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2038705942 ## src/iceberg/transform.h: ## @@ -56,16 +57,98 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +constexpr std::string_view T

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2038705365 ## src/iceberg/transform.h: ## @@ -56,16 +57,98 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +constexpr std::string_view Tra

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036584089 ## src/iceberg/transform.cc: ## @@ -21,55 +21,26 @@ #include -namespace iceberg { +#include "iceberg/type.h" -namespace { -/// \brief Get the relative transfor

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#issuecomment-2792545038 I made the following modifications based on the previous comment: 1. The Transform object is used for JSON serialization/deserialization. 2. Transform::Bind can get the Transfo

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034506563 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034508109 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036516995 ## src/iceberg/type_fwd.h: ## @@ -101,6 +101,7 @@ class StructLike; class TableMetadata; enum class TransformType; class TransformFunction; +struct TransformSpec; Re

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036600412 ## test/transform_test.cc: ## @@ -25,30 +25,48 @@ #include #include +#include "iceberg/transform/transform_function.h" +#include "iceberg/type.h" #include "iceb

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036585617 ## src/iceberg/transform.cc: ## @@ -21,55 +21,26 @@ #include -namespace iceberg { +#include "iceberg/type.h" -namespace { -/// \brief Get the relative transfor

Re: [PR] feat: transform function [iceberg-cpp]

zhjwpku commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036495200 ## src/iceberg/transform.cc: ## @@ -21,55 +21,26 @@ #include -namespace iceberg { +#include "iceberg/type.h" -namespace { -/// \brief Get the relative transform

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034281506 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034394476 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034393074 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034383670 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034371723 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034375471 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034372823 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034363891 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034361080 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034342585 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034179840 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034178885 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033329587 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033327821 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033080461 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033074455 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033070013 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033053211 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2032908900 ## src/iceberg/transform.h: ## @@ -56,14 +56,45 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +constexpr std::string_view ToS

Re: [PR] feat: transform function [iceberg-cpp]

gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2032896374 ## src/iceberg/transform/transform_factory.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r203258 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2032494097 ## src/iceberg/transform.h: ## @@ -56,14 +56,45 @@ enum class TransformType { kVoid, }; +/// \brief Get the relative transform name +constexpr std::string_view ToS

Re: [PR] feat: transform function [iceberg-cpp]

lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2032469032 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre