ZENOTME commented on code in PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992906249
##
crates/iceberg/src/transaction.rs:
##
@@ -267,13 +376,174 @@ trait SnapshotProduceOperation: Send + Sync {
struct DefaultManifestProcess;
impl ManifestProcess
ZENOTME commented on code in PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992977440
##
crates/integration_tests/tests/shared_tests/merge_append_test.rs:
##
@@ -0,0 +1,206 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
ZENOTME commented on code in PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992977440
##
crates/integration_tests/tests/shared_tests/merge_append_test.rs:
##
@@ -0,0 +1,206 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
ZENOTME commented on PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#issuecomment-2720302670
Thanks for review! @jonathanc-n @kevinjqliu. I have refined the code and
fixed the test. I think this PR is ready to review again. also cc @Fokko
@liurenjie1024 @Xuanwo @sdd
--
This
jonathanc-n commented on code in PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1955391542
##
crates/integration_tests/tests/merge_append_test.rs:
##
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
kevinjqliu commented on code in PR #902:
URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1922681882
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1182,6 +1182,12 @@ impl ManifestEntry {
pub fn data_file(&self) -> &DataFile {
&self.data_file
}
