Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r2217361623 ## crates/iceberg/src/transaction/append.rs: ## @@ -108,7 +108,7 @@ impl TransactionAction for FastAppendAction { } } -struct FastAppendOperation; +pub(crate

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r2217166162 ## crates/iceberg/src/transaction/merge_append.rs: ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r2217152429 ## crates/iceberg/src/spec/manifest/entry.rs: ## @@ -130,6 +130,12 @@ impl ManifestEntry { self.snapshot_id } +/// File sequence number +#[in

Re: [PR] feat: support merge append action [iceberg-rust]

CTTY commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r2209181903 ## crates/iceberg/src/transaction/merge_append.rs: ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#issuecomment-3070019074 I have fix this PR to adapt new transcaction framework and ready to review. Recently I will keep up this PR. cc @liurenjie1024 @Xuanwo @Fokko @kevinjqliu @CTTY @jonathanc-n -- This

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992906249 ## crates/iceberg/src/transaction.rs: ## @@ -267,13 +376,174 @@ trait SnapshotProduceOperation: Send + Sync { struct DefaultManifestProcess; impl ManifestProcess

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992977440 ## crates/integration_tests/tests/shared_tests/merge_append_test.rs: ## @@ -0,0 +1,206 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1992977440 ## crates/integration_tests/tests/shared_tests/merge_append_test.rs: ## @@ -0,0 +1,206 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: support merge append action [iceberg-rust]

ZENOTME commented on PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#issuecomment-2720302670 Thanks for review! @jonathanc-n @kevinjqliu. I have refined the code and fixed the test. I think this PR is ready to review again. also cc @Fokko @liurenjie1024 @Xuanwo @sdd -- This

Re: [PR] feat: support merge append action [iceberg-rust]

jonathanc-n commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1955391542 ## crates/integration_tests/tests/merge_append_test.rs: ## @@ -0,0 +1,183 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] feat: support merge append action [iceberg-rust]

kevinjqliu commented on code in PR #902: URL: https://github.com/apache/iceberg-rust/pull/902#discussion_r1922681882 ## crates/iceberg/src/spec/manifest.rs: ## @@ -1182,6 +1182,12 @@ impl ManifestEntry { pub fn data_file(&self) -> &DataFile { &self.data_file }