Re: [PR] feat: sort order [iceberg-cpp]

Fokko commented on PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#issuecomment-2786670179 Thanks @zhjwpku for working on this, and thanks @wgtmac, @lidavidm and @gty404 for the reviews 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] feat: sort order [iceberg-cpp]

Fokko merged PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat: sort order [iceberg-cpp]

wgtmac commented on PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#issuecomment-2785637570 Do you have any comment? @lidavidm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] feat: sort order [iceberg-cpp]

wgtmac commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2025908907 ## test/sort_field_test.cc: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: sort order [iceberg-cpp]

zhjwpku commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2025806406 ## src/iceberg/sort_field.cc: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: sort order [iceberg-cpp]

zhjwpku commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2026148130 ## src/iceberg/sort_field.cc: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: sort order [iceberg-cpp]

wgtmac commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2025914548 ## src/iceberg/sort_field.cc: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: sort order [iceberg-cpp]

zhjwpku commented on PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#issuecomment-2774955037 @Fokko @Xuanwo Please take a look at this PR when you are available, thanks ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] feat: sort order [iceberg-cpp]

zhjwpku commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2026151150 ## test/sort_field_test.cc: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: sort order [iceberg-cpp]

gty404 commented on code in PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#discussion_r2025032497 ## src/iceberg/sort_field.cc: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the