Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 merged PR #275: URL: https://github.com/apache/iceberg-rust/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#issuecomment-2068385611 I think this PR is ready to move. PTAL. I modified the interface a bit to make it easier for error handling. Feel free to let me there is still @Xuanwo @liurenjie1024 @Fokko @sdd -

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1560477918 ## crates/iceberg/src/writer/mod.rs: ## @@ -15,13 +15,69 @@ // specific language governing permissions and limitations // under the License. -//! The iceberg wri

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1560378281 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1560377462 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559757955 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559754777 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559751858 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559727594 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559675925 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559672626 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559671945 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559618368 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1559618368 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

sdd commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1558106190 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1557943458 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1557940399 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1557940399 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1556935437 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

Xuanwo commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1556917470 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#issuecomment-2041377659 > @liurenjie1024 @ZENOTME What's the current status on this PR - as it looks very promising as well as the outlined framework in #34 ? I think this PR is ready to go. > Si

Re: [PR] feat: init iceberg writer [iceberg-rust]

marvinlanhenke commented on PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#issuecomment-2041304545 @liurenjie1024 @ZENOTME What's the current status on this PR - as it looks very promising as well as the outlined framework in #34 ? Since we have already completed so

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1535458284 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1534923644 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1534012662 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1533547101 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1533228766 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1533228766 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1531659605 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: init iceberg writer [iceberg-rust]

viirya commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1530679117 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1529923386 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1529918493 ## crates/iceberg/src/writer/base_writer/data_file_writer.rs: ## @@ -0,0 +1,310 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1529917790 ## crates/iceberg/src/writer/mod.rs: ## @@ -15,14 +15,65 @@ // specific language governing permissions and limitations // under the License. -//! The iceberg wri

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1529903937 ## crates/iceberg/src/writer/mod.rs: ## @@ -15,14 +15,65 @@ // specific language governing permissions and limitations // under the License. -//! The iceberg wri

Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 commented on PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#issuecomment-2006173811 cc @Xuanwo @Fokko PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] feat: init iceberg writer [iceberg-rust]

liurenjie1024 commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1529603925 ## crates/iceberg/src/writer/mod.rs: ## @@ -15,14 +15,65 @@ // specific language governing permissions and limitations // under the License. -//! The icebe

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#issuecomment-2001826958 cc @Fokko @Xuanwo @liurenjie1024 @JanKaul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: init iceberg writer [iceberg-rust]

ZENOTME commented on code in PR #275: URL: https://github.com/apache/iceberg-rust/pull/275#discussion_r1527106928 ## crates/iceberg/src/writer/mod.rs: ## @@ -15,14 +15,65 @@ // specific language governing permissions and limitations // under the License. -//! The iceberg wri