Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-11-01 Thread via GitHub
liurenjie1024 merged PR #600: URL: https://github.com/apache/iceberg-rust/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-11-01 Thread via GitHub
liurenjie1024 commented on PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#issuecomment-2451839743 Thanks @yukkit for this pr! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-10-26 Thread via GitHub
yukkit commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1817714442 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,312 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 commented on PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#issuecomment-2408470892 > remind @liurenjie1024 Sorry for late reply, would you mind to fix comments and resolve conflicts? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1797634121 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-26 Thread via GitHub
yukkit commented on PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#issuecomment-2378319330 remind @liurenjie1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-26 Thread via GitHub
matthewmturner commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1777144414 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,312 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-26 Thread via GitHub
yukkit commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1777112888 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,312 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-24 Thread via GitHub
matthewmturner commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1773470190 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,312 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-10 Thread via GitHub
yukkit commented on PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#issuecomment-2342515435 @liurenjie1024 Please help review the PR again when you get a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-07 Thread via GitHub
yukkit commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1747989388 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,312 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-06 Thread via GitHub
yukkit commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1747927449 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,180 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-05 Thread via GitHub
liurenjie1024 commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1746466160 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,180 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-09-05 Thread via GitHub
liurenjie1024 commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1746464932 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,180 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//