Re: [PR] feat: add s3tables catalog [iceberg-rust]

Xuanwo merged PR #807: URL: https://github.com/apache/iceberg-rust/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#issuecomment-2563579324 @Xuanwo added comments on all the public apis, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896547156 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat: add s3tables catalog [iceberg-rust]

Xuanwo commented on code in PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#discussion_r1896346166 ## crates/catalog/s3tables/src/catalog.rs: ## @@ -0,0 +1,620 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: add s3tables catalog [iceberg-rust]

flaneur2020 commented on PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#issuecomment-2556502230 @Xuanwo i believe the rest part of this pr is adding tests, i've created a real s3tables bucket to test it and it looks work fine, can you give some suggestions about the test part

Re: [PR] feat: add s3tables catalog [iceberg-rust]

Xuanwo commented on PR #807: URL: https://github.com/apache/iceberg-rust/pull/807#issuecomment-2556494901 Hi @flaneur2020, I suggest splitting this PR into multiple ones to make it easier to review and accelerate the iteration speed. -- This is an automated message from the Apache Git Ser