wgtmac commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2084161767
##
src/iceberg/CMakeLists.txt:
##
@@ -36,7 +37,6 @@ set(ICEBERG_SOURCES
transform.cc
transform_function.cc
type.cc
-snapshot.cc
Review Comment:
It
Fokko commented on PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#issuecomment-2871477423
Thanks @wgtmac for adding this, and @lidavidm @zhjwpku for the reviews 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Fokko merged PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2084127518
##
src/iceberg/CMakeLists.txt:
##
@@ -36,7 +37,6 @@ set(ICEBERG_SOURCES
transform.cc
transform_function.cc
type.cc
-snapshot.cc
Review Comment:
Not
wgtmac commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2083538516
##
src/iceberg/name_mapping.cc:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
wgtmac commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2083233139
##
src/iceberg/util/checked_cast_internal.h:
##
@@ -0,0 +1,61 @@
+/*
Review Comment:
I was using it for the visitor but not it is not required. Let me remove it
for
zhjwpku commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2082800454
##
src/iceberg/util/checked_cast_internal.h:
##
@@ -0,0 +1,61 @@
+/*
Review Comment:
Should we install this header by removing the internal suffix? I don't see
it
lidavidm commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2080931836
##
src/iceberg/name_mapping.cc:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. Se
