liurenjie1024 merged PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#discussion_r1695292644
##
crates/iceberg/src/spec/values.rs:
##
@@ -76,7 +76,7 @@ pub enum PrimitiveLiteral {
/// UTF-8 bytes (without length)
String(String),
/// 16-b
Xuanwo commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256024569
> Yes. I think that's why we introduce `Datum`.
Thank you for the reminder! It makes sense for me to remove it now.
--
This is an automated message from the Apache Git Service.
liurenjie1024 commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256026279
> > Yes. I think that's why we introduce `Datum`.
>
> Thank you for the reminder! It makes sense for me to remove it now.
I'll open an issue to track it.
--
This i
liurenjie1024 commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256018387
> It gives me a reflection that do we need the literal type like
`PrimitiveLiteral::Timestamp`. Or we can just use `PrimitiveLiteral::Long`.🤔
Yeah, I also think we no longe
ZENOTME commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2254531291
> > Or we can just use `PrimitiveLiteral::Long`.🤔
>
> Do we always need a specific type to represent logical types? If we
convert `Timestamp` to `Long`, we still need to assign a
Xuanwo commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2254516478
> Or we can just use `PrimitiveLiteral::Long`.🤔
Do we always need a specific type to represent logical types? If we convert
`Timestamp` to `Long`, we still need to assign a type t
ZENOTME commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2254509475
cc @liurenjie1024 @Xuanwo @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ZENOTME commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2254508575
It gives me a reflection that do we need the literal type like
`PrimitiveLiteral::Timestamp`. Or we can just use `PrimitiveLiteral::Long`.🤔
--
This is an automated message from t
