Re: [PR] feat: add base config implementation [iceberg-cpp]

2025-05-12 Thread via GitHub
Fokko merged PR #92: URL: https://github.com/apache/iceberg-cpp/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat: add base config implementation [iceberg-cpp]

2025-05-11 Thread via GitHub
zhjwpku commented on code in PR #92: URL: https://github.com/apache/iceberg-cpp/pull/92#discussion_r2083481119 ## test/config_test.cc: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOT

Re: [PR] feat: add base config implementation [iceberg-cpp]

2025-05-10 Thread via GitHub
lidavidm commented on code in PR #92: URL: https://github.com/apache/iceberg-cpp/pull/92#discussion_r2082996873 ## test/config_test.cc: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] feat: add base config implementation [iceberg-cpp]

2025-05-09 Thread via GitHub
wgtmac commented on code in PR #92: URL: https://github.com/apache/iceberg-cpp/pull/92#discussion_r2081201995 ## src/iceberg/util/config.h: ## @@ -23,11 +23,13 @@ #include #include -namespace iceberg { +#include Review Comment: ```suggestion #include "iceberg/excep