liurenjie1024 merged PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1717033442
##
crates/iceberg/src/spec/partition.rs:
##
@@ -136,6 +145,427 @@ impl UnboundPartitionSpec {
}
}
+impl From for UnboundPartitionField {
+fn from(f
liurenjie1024 commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1716954093
##
crates/iceberg/src/spec/partition.rs:
##
@@ -44,22 +44,27 @@ pub struct PartitionField {
pub transform: Transform,
}
+impl PartitionField {
+///
c-thiel commented on PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#issuecomment-2284445481
@liurenjie1024 ready for another round!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1714069854
##
crates/iceberg/src/spec/partition.rs:
##
@@ -136,6 +145,427 @@ impl UnboundPartitionSpec {
}
}
+impl From for UnboundPartitionField {
+fn from(field:
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1713998496
##
crates/iceberg/src/spec/partition.rs:
##
@@ -136,6 +145,427 @@ impl UnboundPartitionSpec {
}
}
+impl From for UnboundPartitionField {
+fn from(field:
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1713993768
##
crates/iceberg/src/spec/partition.rs:
##
@@ -136,6 +145,427 @@ impl UnboundPartitionSpec {
}
}
+impl From for UnboundPartitionField {
+fn from(field:
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1713990348
##
crates/iceberg/src/spec/partition.rs:
##
@@ -136,6 +145,427 @@ impl UnboundPartitionSpec {
}
}
+impl From for UnboundPartitionField {
+fn from(field:
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1713982541
##
crates/iceberg/src/spec/partition.rs:
##
@@ -44,22 +44,27 @@ pub struct PartitionField {
pub transform: Transform,
}
+impl PartitionField {
+/// To un
liurenjie1024 commented on PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#issuecomment-2273715005
> I adapted the broken tests for predicates. @liurenjie1024 it would be good
to have an extra vigilant eye on those. Most changed needed to be done due to
incompatible schemas fo
liurenjie1024 commented on PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#issuecomment-2273713611
> I checked spark and it also fails:
pyspark.errors.exceptions.captured.IllegalArgumentException: Cannot add
redundant partition: 1000: ts_year: year(2) conflicts with 1001: ts
liurenjie1024 commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1707133092
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a s
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1705249312
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1705248739
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1705248284
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r170524
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#issuecomment-2270712857
> I have a few `ToDo`s in the code. Most of them are for tests in other
modules that would fail with proper partition binding.
>
> If someone has insights on the following, it wo
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704969609
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704331295
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704319118
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704314380
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704310954
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
c-thiel commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704298527
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a schema
liurenjie1024 commented on code in PR #491:
URL: https://github.com/apache/iceberg-rust/pull/491#discussion_r1704049202
##
crates/iceberg/src/spec/partition.rs:
##
@@ -117,22 +144,312 @@ pub struct UnboundPartitionField {
}
/// Unbound partition spec can be built without a s
24 matches
Mail list logo
