Re: [PR] feat: Adding literals [iceberg-go]

2024-05-28 Thread via GitHub
Fokko commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2135444853 @zeroshade Awesome, let's get this in! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-28 Thread via GitHub
Fokko merged PR #76: URL: https://github.com/apache/iceberg-go/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-28 Thread via GitHub
zeroshade commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2135416145 updated and fixed the conflicts @Fokko! :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-26 Thread via GitHub
Fokko commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2132772683 @zeroshade Thanks! Can you fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-24 Thread via GitHub
zeroshade commented on code in PR #76: URL: https://github.com/apache/iceberg-go/pull/76#discussion_r1613885354 ## literals.go: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +/

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-24 Thread via GitHub
zeroshade commented on code in PR #76: URL: https://github.com/apache/iceberg-go/pull/76#discussion_r1613884699 ## literals.go: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +/

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-23 Thread via GitHub
Fokko commented on code in PR #76: URL: https://github.com/apache/iceberg-go/pull/76#discussion_r1611395602 ## literals.go: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// di

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-23 Thread via GitHub
Fokko commented on code in PR #76: URL: https://github.com/apache/iceberg-go/pull/76#discussion_r1611390524 ## literals.go: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// di

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-23 Thread via GitHub
Fokko commented on code in PR #76: URL: https://github.com/apache/iceberg-go/pull/76#discussion_r1611387836 ## literals.go: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// di

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-10 Thread via GitHub
wolfeidau commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2105542638 @zeroshade this is a considerable amount of work, I really need to learn more about the internals of iceberg, mostly working to understand the metadata. Looks great, nothing stands

Re: [PR] feat: Adding literals [iceberg-go]

2024-05-09 Thread via GitHub
zeroshade commented on PR #76: URL: https://github.com/apache/iceberg-go/pull/76#issuecomment-2103261639 CC @Fokko @nastra @wolfeidau -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific