Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-14 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1915921905 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOT

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-14 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1915663329 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-10 Thread via GitHub
Fokko commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1911238543 ## catalog/glue.go: ## @@ -47,13 +50,65 @@ const ( // The ID of the Glue Data Catalog where the tables reside. If none is provided, Glue // automaticall

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-10 Thread via GitHub
zeroshade merged PR #244: URL: https://github.com/apache/iceberg-go/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-08 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1908133151 ## catalog/rest_test.go: ## @@ -114,6 +114,39 @@ func (r *RestCatalogSuite) TestToken200() { r.Equal(r.configVals.Get("warehouse"), "s3://some-bucket") }

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-08 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1907519396 ## catalog/rest_test.go: ## @@ -114,6 +114,39 @@ func (r *RestCatalogSuite) TestToken200() { r.Equal(r.configVals.Get("warehouse"), "s3://some-bucket") }

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-08 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1907519396 ## catalog/rest_test.go: ## @@ -114,6 +114,39 @@ func (r *RestCatalogSuite) TestToken200() { r.Equal(r.configVals.Get("warehouse"), "s3://some-bucket") }

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-08 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1907510409 ## catalog/glue.go: ## @@ -54,6 +57,50 @@ var ( _ Catalog = (*GlueCatalog)(nil) ) +func init() { + Register("glue", RegistrarFunc(func(_ string, pro

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906464859 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOT

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906454658 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906174773 ## catalog/rest_test.go: ## @@ -114,6 +114,39 @@ func (r *RestCatalogSuite) TestToken200() { r.Equal(r.configVals.Get("warehouse"), "s3://some-bucket") }

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906160998 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOT

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906137219 ## catalog/glue.go: ## @@ -54,6 +57,50 @@ var ( _ Catalog = (*GlueCatalog)(nil) ) +func init() { + Register("glue", RegistrarFunc(func(_ string, pro

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
zeroshade commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906136606 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

Re: [PR] feat(catalog): Add Catalog Registry [iceberg-go]

2025-01-07 Thread via GitHub
kevinjqliu commented on code in PR #244: URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1906120334 ## catalog/registry.go: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOT