Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-26 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1467757335 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-26 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1467303335 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1467303335 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1467303335 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1467303335 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466788214 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466788214 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466774496 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466763472 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
HonahX commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466763472 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466736215 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store met

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466705205 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store meta

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466705205 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store meta

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on PR #305: URL: https://github.com/apache/iceberg-python/pull/305#issuecomment-1910658396 Could you also add a section to the documentation? Would be a pity if people aren't able to find this feature :) -- This is an automated message from the Apache Git Service. To respo

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466700679 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466698605 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIceb

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466694858 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIce

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
syun64 commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466689445 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store met

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466685651 ## pyiceberg/io/pyarrow.py: ## @@ -906,6 +986,76 @@ def after_map_value(self, element: pa.Field) -> None: self._field_names.pop() +class _ConvertToIceb

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466683944 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store meta

Re: [PR] create_table with PyArrow Schema [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #305: URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1466683196 ## pyiceberg/catalog/dynamodb.py: ## @@ -152,6 +156,14 @@ def create_table( ValueError: If the identifier is invalid, or no path is given to store meta