xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562893009
This is quite funny 🤣
https://github.com/user-attachments/assets/c1b95f69-08cd-4f6d-8e2f-4ee5c9573af3";
/>
--
This is an automated message from the Apache Git Service.
To resp
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562885996
Then I think we need to separate the integration's build/test from core
library in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562884529
Oh, just noticed the compilation error is indeed in datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562883753
> > I know we want to use nighty for fmt and check. But we should use `msrv`
for build.
>
> We currently only have `msrv` for `iceberg`. I'm not sure if our goal is
to maintain `
Xuanwo commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562881230
> use nightly for build
This is fine since it's the version we use to develop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Xuanwo commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562880940
> I know we want to use nighty for fmt and check. But we should use `msrv`
for build.
We currently only have `msrv` for `iceberg`. I'm not sure if our goal is to
maintain `msrv`
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562880311
@Xuanwo How should we proceed? Increase MSRV and fix build, or use nightly
for build, which one do you prefer?
--
This is an automated message from the Apache Git Service.
To respond
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562877442
Well, we can see `msrv` isn't working
https://github.com/user-attachments/assets/ba1d0cd5-9e0f-4890-a5b1-a23faf1104d6";
/>
--
This is an automated message from the Apache Git S
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562876608
I know we want to use nighty for fmt and check. But we should use `msrv` for
build.
And we don't need to install both nighly and stable for them.
--
This is an automated messag
Xuanwo commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562871196
> We can verify that currently CI uses nightly, instead of `rust_msrv`
Hi, it is intentional that we are using the nightly version for CI, as
specified in
https://github.com/apac
xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562860812
We can verify that currently CI uses nightly, instead of `rust_msrv`
https://github.com/user-attachments/assets/836867d6-850c-41cb-8236-6ef514b7920f";
/>
--
This is an automat
11 matches
Mail list logo
