Xuanwo merged PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
ZENOTME commented on PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2642343385
cc @liurenjie1024 @Xuanwo @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ZENOTME commented on code in PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#discussion_r1946198059
##
crates/integration_tests/tests/shared_tests/mod.rs:
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
gruuya commented on code in PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#discussion_r1946050715
##
crates/integration_tests/tests/shared_tests/mod.rs:
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
ZENOTME commented on PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2640582262
> Hey @ZENOTME @Fokko, can you also take a look at this proposal?
Thanks! @gruuya It's a great job to improve our ci. the idea and code change
LGTM.
--
This is an automated me
ZENOTME commented on code in PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#discussion_r1945180516
##
crates/integration_tests/tests/shared_tests/mod.rs:
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
gruuya commented on PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2633053094
Hey @ZENOTME @Fokko, can you also take a look at this proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kevinjqliu commented on PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2631453840
thats amazing! Thanks for looking into that, i like faster CI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gruuya commented on PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2630198784
> thanks! generally lgtm. Does this also affect CI runs? if so, would be
great to also include how much time we saved there too.
Good question; a brief glance suggests it may have
