kevinjqliu commented on PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#issuecomment-2264540426
Thanks for the contribution @ndrluis!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kevinjqliu merged PR #988:
URL: https://github.com/apache/iceberg-python/pull/988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ice
ndrluis commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700887563
##
pyiceberg/utils/properties.py:
##
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
kevinjqliu commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700608965
##
pyiceberg/utils/properties.py:
##
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
ndrluis commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700300364
##
pyiceberg/expressions/literals.py:
##
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Lit
sungwy commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700271363
##
pyiceberg/expressions/literals.py:
##
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Lite
ndrluis commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700215719
##
pyiceberg/expressions/literals.py:
##
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Lit
ndrluis commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1700166156
##
pyiceberg/expressions/literals.py:
##
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Lit
sungwy commented on code in PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#discussion_r1699244665
##
pyiceberg/expressions/literals.py:
##
@@ -588,7 +589,7 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
def _(self, type_var: BooleanType) -> Lite
sungwy commented on PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#issuecomment-2261291991
Yes that sounds like a good idea - the name does sound a bit redundant
leaving it as it is:
`from pyiceberg.utils.properties import PropertyUtil` - it's quite the
tongue twiste
ndrluis commented on PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#issuecomment-2261270963
Yes, I think that makes sense. What do you think about extracting the
methods from the `PropertyUtil` class into functions in the
`pyiceberg/utils/properties.py` module?
--
This i
sungwy commented on PR #988:
URL: https://github.com/apache/iceberg-python/pull/988#issuecomment-2261252104
Thank you for cleaning this up @ndrluis
I think it would also make sense to move `PropertyUtil` out of
`pyiceberg/table/__init__.py` to a new file, like
`pyiceberg/utils/prope
12 matches
Mail list logo
