Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-08-07 Thread via GitHub
guitcastro commented on PR #741: URL: https://github.com/apache/iceberg-python/pull/741#issuecomment-2274893639 > @Fokko thanks a lot for your feedback - I added docs and the constant. The constant is a very good idea - I hope we will be able to use remote signing with FileIO as well eventu

Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-05-31 Thread via GitHub
Fokko merged PR #741: URL: https://github.com/apache/iceberg-python/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-05-31 Thread via GitHub
Fokko commented on PR #741: URL: https://github.com/apache/iceberg-python/pull/741#issuecomment-2142322807 @c-thiel The idea is to support both. The problem is that with Arrow it is hard to inject in the signing process, since most of the code is pushed down to the C level, and there are no

Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-05-23 Thread via GitHub
c-thiel commented on PR #741: URL: https://github.com/apache/iceberg-python/pull/741#issuecomment-2127322592 @Fokko I added docs and the constant. The constant is a very good idea - I hope we will be able to use remote signing with FileIO as well eventually. Right now only the fsspec impl

Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-05-23 Thread via GitHub
Fokko commented on PR #741: URL: https://github.com/apache/iceberg-python/pull/741#issuecomment-2127020569 @c-thiel Since it is in Java, I think it is fair to add it here. Two things: - Can you mention it in the docs as well? - Should we introduce a constant? -- This is an autom

Re: [PR] Update fsspec.py to respect s3.signer.uri property [iceberg-python]

2024-05-19 Thread via GitHub
c-thiel commented on PR #741: URL: https://github.com/apache/iceberg-python/pull/741#issuecomment-2119193916 @amogh-jahagirdar any thoughts about this PR? Would this be OK to incorporate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on