kevinjqliu merged PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#issuecomment-2683661782
Thanks for the PR @geruh and thanks for the review @smaheshwar-pltr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
kevinjqliu commented on code in PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#discussion_r1970666991
##
mkdocs/docs/configuration.md:
##
Review Comment:
can you also update the table?
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/con
smaheshwar-pltr commented on code in PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#discussion_r1970671110
##
mkdocs/docs/configuration.md:
##
Review Comment:
Also
> Note: the default value of True differs from Iceberg's Java implementation
shou
kevinjqliu commented on code in PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#discussion_r1970669793
##
mkdocs/docs/configuration.md:
##
Review Comment:
also in SimpleLocationProvider too, the part
```
The `SimpleLocationProvider` is enabled f
kevinjqliu commented on code in PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#discussion_r1970666991
##
mkdocs/docs/configuration.md:
##
Review Comment:
can you also update the table's default value for
`write.object-storage.enabled`?
https://github
kevinjqliu commented on code in PR #1724:
URL: https://github.com/apache/iceberg-python/pull/1724#discussion_r1970668787
##
mkdocs/docs/configuration.md:
##
Review Comment:
and the "It is used by default." part
--
This is an automated message from the Apache Git Service
