Fokko commented on PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2625292714
Less is more, thanks @kevinjqliu 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kevinjqliu merged PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2625285068
Already added in #1554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Fokko commented on PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2624965210
Ah good catch @kevinjqliu. Probably the `type: ignore` hid the error from
the linter, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message
kevinjqliu commented on PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2624744839
@Fokko I meant this change already exists on
[L568](https://github.com/apache/iceberg-python/pull/1587/files#diff-a7fbd8c6b0564308ca872ba479f0e240ff2c893d15776a14e52b91b48e9ac470
Fokko commented on PR #1587:
URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2624276063
@kevinjqliu Maybe you already saw this at the Deletion Vector PR:
https://github.com/apache/iceberg-python/pull/1516/files#diff-a7fbd8c6b0564308ca872ba479f0e240ff2c893d15776a14e52b91b
