Re: [PR] Table commit retries based on table properties [iceberg-python]

2024-05-13 Thread via GitHub
syun64 commented on code in PR #330: URL: https://github.com/apache/iceberg-python/pull/330#discussion_r1598837560 ## tests/table/test_init.py: ## @@ -1125,3 +1128,122 @@ def test_serialize_commit_table_request() -> None: deserialized_request = CommitTableRequest.model_v

Re: [PR] Table commit retries based on table properties [iceberg-python]

2024-03-18 Thread via GitHub
Buktoria commented on PR #330: URL: https://github.com/apache/iceberg-python/pull/330#issuecomment-2004665217 So I made a large fundamental change to the original design, where catalogs need to implement a function where they declare what exceptions are retryable. This becomes the bridge be

Re: [PR] Table commit retries based on table properties [iceberg-python]

2024-02-01 Thread via GitHub
Buktoria commented on code in PR #330: URL: https://github.com/apache/iceberg-python/pull/330#discussion_r1474754856 ## pyiceberg/table/__init__.py: ## @@ -994,6 +1065,7 @@ def refs(self) -> Dict[str, SnapshotRef]: """Return the snapshot references in the table."""

Re: [PR] Table commit retries based on table properties [iceberg-python]

2024-02-01 Thread via GitHub
Fokko commented on code in PR #330: URL: https://github.com/apache/iceberg-python/pull/330#discussion_r1473948988 ## pyiceberg/table/__init__.py: ## @@ -791,6 +792,76 @@ class CommitTableResponse(IcebergBaseModel): metadata_location: str = Field(alias="metadata-location")