dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2134126834
See #10329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
dimas-b closed pull request #10283: Support special chars in S3URI
URL: https://github.com/apache/iceberg/pull/10283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2109039866
> I still feel we want to discourage (if not disallow) special characters in
paths due to cross compatibility issues.
I made a comment under #10329 proposing an escaping method th
amogh-jahagirdar commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2108850538
> Overall, I think it's better to fail fast where interoperability is a
concern as that's more important than supporting the full s3 key space.
After seeing a variety of
danielcweeks commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2108825075
@dimas-b I just put up https://github.com/apache/iceberg/pull/10329 to
address the field name encoding. This should also address the quotes issue as
well since it will be encoded.
dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2103400187
> this change would likely be incompatible with S3AFileSystem or any other
system that uses the java URI implementation. [...]
I believe we are already in this situation even with
danielcweeks commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2103091902
@dimas-b Unfortunately, I agree there will likely be problems if people use
special characters in the pathing prefix that's outside of Iceberg's control,
but overall, I think we wa
dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2102663607
Encoding special chars in partition path elements sounds like a good idea,
but I'm not sure it is that simple
However, the problem is not specific to what Iceberg code puts The ba
dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2100455393
@jackye1995 : Would you think about special chars in S3 URIs? I'd appreciate
your insight. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the messa
snazy commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2099816561
> there are cases where they are used
As (not so widely) known, special characters in S3 URIs - i.e. those URIs,
for example with (back)quotes and hash/question-marks, are not prope
danielcweeks commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2099593480
We shouldn't remove the param/fragment handling because even though they
aren't typically used, they are accepted by s3 and there are cases where they
are used. This would change
11 matches
Mail list logo
