Re: [PR] Support reading initial-defaults [iceberg-python]

2025-04-22 Thread via GitHub
Fokko commented on PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#issuecomment-2823167124 @kevinjqliu Sure, but I think this relies on https://github.com/apache/iceberg-python/pull/1770 to do some proper testing 👍 -- This is an automated message from the Apache Git Ser

Re: [PR] Support reading initial-defaults [iceberg-python]

2025-04-19 Thread via GitHub
kevinjqliu commented on PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#issuecomment-2816820435 @Fokko could you rebase this when you get a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Support reading initial-defaults [iceberg-python]

2025-02-14 Thread via GitHub
gabeiglio commented on PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#issuecomment-2660194994 No problem! I was trying to get a test case for this by evolving the schema of a table and adding a new field with some initial-default value, but i think we have to wait for V3

Re: [PR] Support reading initial-defaults [iceberg-python]

2025-02-14 Thread via GitHub
Fokko commented on PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#issuecomment-2660123523 > Since initial-default projection happens after filtering in _task_to_record_batches Im wondering if this will yield the correct results given a pyarrow_filter for this field.

Re: [PR] Support reading initial-defaults [iceberg-python]

2025-02-12 Thread via GitHub
gabeiglio commented on PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#issuecomment-2654880947 Since initial-default projection happens after filtering in _task_to_record_batches wondering if this will yield the correct results given a pyarrow_filter for this field. --