kevinjqliu commented on code in PR #1188:
URL: https://github.com/apache/iceberg-python/pull/1188#discussion_r1768989235
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,8 +1068,17 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
kevinjqliu commented on code in PR #1188:
URL: https://github.com/apache/iceberg-python/pull/1188#discussion_r1768984958
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,8 +1068,17 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
zaryab-ali commented on PR #1188:
URL: https://github.com/apache/iceberg-python/pull/1188#issuecomment-2364191346
@kevinjqliu can you please review my PR and let me know if i made a mistake
(please check with extra caution as it is my first contribution to any open
source project)
--
Th
