Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-24 Thread via GitHub
nastra merged PR #9368: URL: https://github.com/apache/iceberg/pull/9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551603 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkStagedScan.java: ## @@ -39,11 +38,6 @@ public class TestSparkStagedScan extends CatalogTest

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551324 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java: ## @@ -50,7 +50,7 @@ public void removeTables() { sql("DROP TABLE IF E

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551103 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -35,11 +38,25 @@ import org.assertj.core.api.Assertions; import org.junit.ju

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435550886 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java: ## @@ -30,7 +29,7 @@ public abstract class CatalogTestBase extends TestBaseWithCatalog