Re: [PR] Spark: Support renaming views [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1453638953 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -635,6 +633,118 @@ private Catalog tableCatalog() { return Sp

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-16 Thread via GitHub
nastra merged PR #9343: URL: https://github.com/apache/iceberg/pull/9343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-16 Thread via GitHub
nastra commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1453069623 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -635,6 +633,118 @@ private Catalog tableCatalog() { return Sp

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
nastra commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1453045834 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -635,6 +633,118 @@ private Catalog tableCatalog() { return Sp

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
ajantha-bhat commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1452861042 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -635,6 +633,118 @@ private Catalog tableCatalog() { ret

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1452826597 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -90,9 +94,20 @@ case class Extended

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1452827023 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -635,6 +633,118 @@ private Catalog tableCatalog() { return Sp

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1452826597 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -90,9 +94,20 @@ case class Extended

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-15 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1452826314 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +54,11 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-05 Thread via GitHub
nastra commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442615912 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +57,17 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442153222 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -590,10 +591,7 @@ public void fullFunctionIdentifier() { @Test

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442152596 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +57,17 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442151540 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +57,17 @@ case class ResolveViews(spark: SparkSessio