Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

github-actions[bot] closed pull request #9192: Spark: IN clause on system function is not pushed down URL: https://github.com/apache/iceberg/pull/9192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

github-actions[bot] commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-2412570842 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1990954605 @aokolnychyi I see you fixed part of this in https://github.com/apache/iceberg/pull/9873 but Spark 3.4 looks stil bugged on main. Do you have any time to give me a feedback on this? --

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1983240856 > just FYI, looks like there's a related PR that @aokolnychyi opened for this: #9873 thanks, watching that 🙏 -- This is an automated message from the Apache Git Service. To res

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

nastra commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1983096811 just FYI, looks like there's a related PR that @aokolnychyi opened for this: https://github.com/apache/iceberg/pull/9873 -- This is an automated message from the Apache Git Service. To r

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

nastra commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1919260424 @aokolnychyi could you take a look at this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1905614023 any chance to have this reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

wypoon commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1863749851 @rdblue @szehon-ho @RussellSpitzer can you please review this? Also, can you please enable the CI for this PR? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

wypoon commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1431856870 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -56,7 +69,6 @@ object ReplaceStaticInvoke extends

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1862263371 Thanks @wypoon for the review, I addressed your concerns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

wypoon commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1430865455 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -40,14 +37,23 @@ import org.apache.spark.sql.types

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1420295733 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -40,14 +37,20 @@ import org.apache.spark.sql.typ

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1420295367 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownDQL.java: ## @@ -224,6 +226,35 @@ private void testBucketLon

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1846982769 Thanks for the review, I addressed your concerns. If I get green light I proceed to copy-paste over 3.4 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

advancedxy commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1420230467 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownDQL.java: ## @@ -224,6 +226,35 @@ private void testBucketL

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1420130446 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownDQL.java: ## @@ -224,6 +226,35 @@ private void testBucketLon

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

advancedxy commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1419869752 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -40,14 +37,20 @@ import org.apache.spark.sql.t

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1845761731 cc @nastra @dramaticlly @advancedxy for review thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1419314263 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -40,14 +37,20 @@ import org.apache.spark.sql.typ

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

ConeyLiu commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1845465132 @tmnd1991 thanks for your contribution. I think this is a valid fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

ConeyLiu commented on code in PR #9192: URL: https://github.com/apache/iceberg/pull/9192#discussion_r1419067449 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala: ## @@ -40,14 +37,20 @@ import org.apache.spark.sql.typ

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1845066093 Can I have a feedback on this one @ConeyLiu, too? Thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th