Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi commented on PR #8959: URL: https://github.com/apache/iceberg/pull/8959#issuecomment-1791856684 Thanks, @flyrain! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi merged PR #8959: URL: https://github.com/apache/iceberg/pull/8959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi commented on code in PR #8959: URL: https://github.com/apache/iceberg/pull/8959#discussion_r1380984561 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -104,13 +107,20 @@ public class RewriteManifestsSparkActi

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi commented on code in PR #8959: URL: https://github.com/apache/iceberg/pull/8959#discussion_r1380984561 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -104,13 +107,20 @@ public class RewriteManifestsSparkActi

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi commented on code in PR #8959: URL: https://github.com/apache/iceberg/pull/8959#discussion_r1380975737 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -73,8 +73,10 @@ * * By default, this action rewrites

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-11-02 Thread via GitHub
flyrain commented on code in PR #8959: URL: https://github.com/apache/iceberg/pull/8959#discussion_r1380821842 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -73,8 +73,10 @@ * * By default, this action rewrites all

Re: [PR] Spark: Fix usage of staging location when optimizing metadata [iceberg]

2023-10-31 Thread via GitHub
aokolnychyi commented on code in PR #8959: URL: https://github.com/apache/iceberg/pull/8959#discussion_r1377997350 ## spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -133,15 +143,17 @@ public RewriteManifestsSparkAction re