Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

2025-01-24 Thread via GitHub
nastra merged PR #12048: URL: https://github.com/apache/iceberg/pull/12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

2025-01-23 Thread via GitHub
nastra commented on code in PR #12048: URL: https://github.com/apache/iceberg/pull/12048#discussion_r1928166943 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -739,23 +749,31 @@ private Table createTablePartiti

Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

2025-01-23 Thread via GitHub
nastra commented on PR #12048: URL: https://github.com/apache/iceberg/pull/12048#issuecomment-2611729505 thanks for the reviews @RussellSpitzer @aokolnychyi. I'll go ahead and merge this for 1.8.0 since I don't have the PR ready yet where we would support minor compactions for DVs -- Th

Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

2025-01-23 Thread via GitHub
RussellSpitzer commented on code in PR #12048: URL: https://github.com/apache/iceberg/pull/12048#discussion_r1927198851 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -739,23 +749,31 @@ private Table createTabl