nastra merged PR #10055:
URL: https://github.com/apache/iceberg/pull/10055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #10055:
URL: https://github.com/apache/iceberg/pull/10055#issuecomment-2027962915
thanks for the reviews @manuzhang and @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rdblue commented on code in PR #10055:
URL: https://github.com/apache/iceberg/pull/10055#discussion_r1543785185
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -348,6 +349,64 @@ public void testBranchReference() {
assertEquals("Snapshot
nastra commented on code in PR #10055:
URL: https://github.com/apache/iceberg/pull/10055#discussion_r1543062498
##
docs/docs/spark-queries.md:
##
@@ -124,6 +124,27 @@ SELECT * FROM prod.db.table.`tag_historical-snapshot`;
Note that the identifier with branch or tag may not be
manuzhang commented on code in PR #10055:
URL: https://github.com/apache/iceberg/pull/10055#discussion_r1542707021
##
docs/docs/spark-writes.md:
##
@@ -201,6 +201,10 @@ Note WAP branch and branch identifier cannot both be
specified.
Also, the branch must exist before performin
manuzhang commented on code in PR #10055:
URL: https://github.com/apache/iceberg/pull/10055#discussion_r1542705533
##
docs/docs/spark-queries.md:
##
@@ -124,6 +124,27 @@ SELECT * FROM prod.db.table.`tag_historical-snapshot`;
Note that the identifier with branch or tag may not
