nastra merged PR #9286:
URL: https://github.com/apache/iceberg/pull/9286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
wypoon commented on code in PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#discussion_r1430738649
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -283,23 +291,31 @@ public void testUseSnapshotIdForTagReferenceAsOf() {
}
@
wypoon commented on code in PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#discussion_r1430738477
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -234,23 +234,31 @@ public void testVersionAsOf() {
}
@Test
- public void t
wypoon commented on PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#issuecomment-1861836102
@nastra thanks for reviewing. I have updated the comments as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nastra commented on code in PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#discussion_r1430388985
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -283,23 +291,31 @@ public void testUseSnapshotIdForTagReferenceAsOf() {
}
@
nastra commented on code in PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#discussion_r1430388075
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -283,23 +291,31 @@ public void testUseSnapshotIdForTagReferenceAsOf() {
}
@
nastra commented on code in PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#discussion_r1430387289
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -234,23 +234,31 @@ public void testVersionAsOf() {
}
@Test
- public void t
wypoon commented on PR #9286:
URL: https://github.com/apache/iceberg/pull/9286#issuecomment-1859545554
@nastra would be great if you reviewed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
