Re: [PR] Spark: Add support for Iceberg views [iceberg]

2024-02-24 Thread via GitHub
nastra closed pull request #9332: Spark: Add support for Iceberg views URL: https://github.com/apache/iceberg/pull/9332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2024-02-24 Thread via GitHub
nastra commented on PR #9332: URL: https://github.com/apache/iceberg/pull/9332#issuecomment-1962328022 Closing this as all of the functionality has been merged individually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431576583 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/ResolvedV2View.scala: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431261945 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on PR #9332: URL: https://github.com/apache/iceberg/pull/9332#issuecomment-1862481789 We discussed internally to split this PR out into smaller pieces. I've created https://github.com/apache/iceberg/pull/9340 -- This is an automated message from the Apache Git Service. To

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431103608 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431099803 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431095931 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1431087038 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430883652 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430726050 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430723981 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/ResolvedV2View.scala: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430722480 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430721984 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430720790 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430720137 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430719038 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430715685 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
aokolnychyi commented on PR #9332: URL: https://github.com/apache/iceberg/pull/9332#issuecomment-1861415591 I should be able to take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430447699 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430442941 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -122,37 +147,132 @@ class Iceb

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430438547 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430033876 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430028232 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430026625 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for Iceberg views [iceberg]

2023-12-18 Thread via GitHub
nastra commented on code in PR #9332: URL: https://github.com/apache/iceberg/pull/9332#discussion_r1430021109 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Softwa