Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao closed pull request #11583: Spark: 4.0 snapshot support URL: https://github.com/apache/iceberg/pull/11583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2711818415 It's much easier to create a new PR than rebasing this one. I will close this PR for now and create a new one instead. -- This is an automated message from the Apache Git Service.

Re: [PR] Spark: 4.0 snapshot support [iceberg]

szehon-ho commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2705116805 Thanks a lot for working on it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2705029804 @szehon-ho I am working on my local. There are still a few test failures. I will push the changes to upstream once I fix all the test failures. -- This is an automated message from

Re: [PR] Spark: 4.0 snapshot support [iceberg]

szehon-ho commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2704765194 While we wait for Spark 4.0 final release, I think we can just merge this against latest RC if you manage to rebase before that, to unblock other work, and can change once the final R

Re: [PR] Spark: 4.0 snapshot support [iceberg]

szehon-ho commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2695877264 Hi @huaxingao can we rebase against the latest Spark 4.0 RC2 ? https://github.com/apache/spark/tree/v4.0.0-rc2 @danielcweeks wanted to see if we can start testing against thi

Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-269589 @szehon-ho will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Spark: 4.0 snapshot support [iceberg]

github-actions[bot] closed pull request #11583: Spark: 4.0 snapshot support URL: https://github.com/apache/iceberg/pull/11583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Spark: 4.0 snapshot support [iceberg]

github-actions[bot] commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2571807236 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark: 4.0 snapshot support [iceberg]

github-actions[bot] commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2564878514 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark: 4.0 snapshot support [iceberg]

pan3793 commented on code in PR #11583: URL: https://github.com/apache/iceberg/pull/11583#discussion_r1862876580 ## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: 4.0 snapshot support [iceberg]

pan3793 commented on code in PR #11583: URL: https://github.com/apache/iceberg/pull/11583#discussion_r1862876580 ## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2486307054 @manuzhang The old PR has some conflicting files. If I rebase, it will also pick up changes for Spark 3.5, which I don't want. So, I opened a new PR. -- This is an automated message

Re: [PR] Spark: 4.0 snapshot support [iceberg]

manuzhang commented on PR #11583: URL: https://github.com/apache/iceberg/pull/11583#issuecomment-2485005072 https://github.com/apache/iceberg/pull/11257 is no longer valid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Spark: 4.0 snapshot support [iceberg]

huaxingao commented on code in PR #11583: URL: https://github.com/apache/iceberg/pull/11583#discussion_r1847696050 ## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Spark: 4.0 snapshot support [iceberg]

pan3793 commented on code in PR #11583: URL: https://github.com/apache/iceberg/pull/11583#discussion_r1847687552 ## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Spark: 4.0 snapshot support [iceberg]

pan3793 commented on code in PR #11583: URL: https://github.com/apache/iceberg/pull/11583#discussion_r1847687552 ## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwa