amitgilad3 commented on PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2934955694
@Fokko gentle ping, was wondering if we still have any blockers ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
amitgilad3 commented on PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2888434137
Hey @Fokko - just wanted to say thanks for reviewing (really appreciate it)
.
I fixed all your comments and added a test to test v1 -> v2 , hope all pass
now.
let me know
Fokko commented on code in PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#discussion_r2093688570
##
pyiceberg/table/update/snapshot.py:
##
@@ -524,6 +531,153 @@ def _process_manifests(self, manifests:
List[ManifestFile]) -> List[ManifestFile
return
Fokko commented on PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2887691980
Looks like the CI is sad 😞
```
tests/integration/test_writes/test_rewrite_manifests.py:154: error:
"rewrite_manifests" of "Table" does not return a value (it only ever retu
Fokko commented on PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2812970719
@amitgilad3 gentle ping, are you still interested in working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
amitgilad3 commented on PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2813045613
Hey @Fokko , yes i am very interested in finishing this, must of missed this
(sorry) , will look at this later today :)
--
This is an automated message from the Apache Git Ser
Fokko commented on code in PR #1661:
URL: https://github.com/apache/iceberg-python/pull/1661#discussion_r1987938857
##
pyiceberg/table/update/snapshot.py:
##
@@ -477,6 +478,20 @@ def _deleted_entries(self) -> List[ManifestEntry]:
return []
+@dataclass(init=False)
R
