Re: [PR] Revert "Support wasb[s] paths in ADLSFileIO" [iceberg]

2024-10-18 Thread via GitHub
nastra merged PR #11344: URL: https://github.com/apache/iceberg/pull/11344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Revert "Support wasb[s] paths in ADLSFileIO" [iceberg]

2024-10-17 Thread via GitHub
danielcweeks commented on PR #11344: URL: https://github.com/apache/iceberg/pull/11344#issuecomment-2420833542 > Can we have some examples though to guard against these changes in the future? Strings that won't parse correctly? There are a lot of subtle issues like hashCode and equali

Re: [PR] Revert "Support wasb[s] paths in ADLSFileIO" [iceberg]

2024-10-17 Thread via GitHub
mrcnc commented on PR #11344: URL: https://github.com/apache/iceberg/pull/11344#issuecomment-2420687278 I'll follow up with another PR that doesn't use java.net.URI for parsing. I'm happy to have more 👀 on this -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Revert "Support wasb[s] paths in ADLSFileIO" [iceberg]

2024-10-17 Thread via GitHub
RussellSpitzer commented on PR #11344: URL: https://github.com/apache/iceberg/pull/11344#issuecomment-2420666877 @mrcnc Can chime in on that, but I think that's fine. Can we have some examples though to guard against these changes in the future? Strings that won't parse correctly? -- Thi

Re: [PR] Revert "Support wasb[s] paths in ADLSFileIO" [iceberg]

2024-10-17 Thread via GitHub
danielcweeks commented on PR #11344: URL: https://github.com/apache/iceberg/pull/11344#issuecomment-2420655723 I'm not actually opposed to the WASB path support, just concerned about the introduction of the URI class for parsing locations. Is it possible to just revert to the old parsing o