Fokko commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1759635303
Thanks @jbonofre for taking the lead on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko merged PR #8722:
URL: https://github.com/apache/iceberg/pull/8722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
jbonofre commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1759631883
`master` branch has been renamed to `main`.
@Fokko @nastra if you can merge this PR when you have time, it would be
great. Thanks !
--
This is an automated message from the Apa
ajantha-bhat commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1757880953
@jbonofre: LGTM. Thanks for fixing the formatting too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jbonofre commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1757827191
As soon as @ajantha-bhat vote +1 on this PR, I will create the ticket at
Apache INFRA to trigger the rename.
--
This is an automated message from the Apache Git Service.
To respond to
jbonofre commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1757826172
@ajantha-bhat I did a rebase to remove the python related resources, and the
"formatting" should be OK now.
--
This is an automated message from the Apache Git Service.
To respond to t
jbonofre commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1355110756
##
.github/workflows/python-release.yml:
##
@@ -51,7 +51,7 @@ jobs:
- name: Set version
run: python -m poetry version "${{ inputs.version }}"
jbonofre commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1750244656
Thanks, I do a cleanup on this PR and I create a INFRA ticket to actually
rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jbonofre commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1749444235
@rdblue no impact on the existing PRs: they will be "attached" to main
instead of master. The only impact is for the remotes for our users.
--
This is an automated message from the Ap
rdblue commented on PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#issuecomment-1749425255
@jbonofre, how will this affect existing PRs? Do all of them need to be
reopened against main instead of master?
--
This is an automated message from the Apache Git Service.
To respond t
rdblue commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347814726
##
.github/workflows/python-release.yml:
##
@@ -51,7 +51,7 @@ jobs:
- name: Set version
run: python -m poetry version "${{ inputs.version }}"
wo
jbonofre commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347247075
##
docs/flink-writes.md:
##
@@ -270,4 +270,4 @@ INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true')
*/
...
```
-Check out all the options here:
[write-opt
ajantha-bhat commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347234482
##
docs/flink-writes.md:
##
@@ -270,4 +270,4 @@ INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true')
*/
...
```
-Check out all the options here:
[write
jbonofre commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347144486
##
docs/flink-writes.md:
##
@@ -270,4 +270,4 @@ INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true')
*/
...
```
-Check out all the options here:
[write-opt
ajantha-bhat commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347108071
##
docs/metrics-reporting.md:
##
@@ -171,4 +171,4 @@ TableScan tableScan =
try (CloseableIterable fileScanTasks = tableScan.planFiles()) {
// ...
}
-```
\ No
jbonofre commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347085171
##
README.md:
##
@@ -36,9 +36,9 @@ The core Java library that tracks table snapshots and
metadata is complete, but
The [Iceberg format specification][iceberg-spec]
nastra commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347081505
##
README.md:
##
@@ -36,9 +36,9 @@ The core Java library that tracks table snapshots and
metadata is complete, but
The [Iceberg format specification][iceberg-spec] i
17 matches
Mail list logo
