Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-11-06 Thread via GitHub
kevinjqliu merged PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-11-05 Thread via GitHub
kevinjqliu commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1830086971 ## pyiceberg/io/pyarrow.py: ## @@ -390,7 +391,14 @@ def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) -> FileSyste gcs_kwa

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-11-05 Thread via GitHub
Fokko commented on PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#issuecomment-2458178171 Thanks @kevinjqliu, using `get_first_property_value` is much cleaner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-11-05 Thread via GitHub
kevinjqliu commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1829809442 ## pyiceberg/io/fsspec.py: ## @@ -171,6 +172,14 @@ def _gs(properties: Properties) -> AbstractFileSystem: # https://gcsfs.readthedocs.io/en/latest/api.ht

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-29 Thread via GitHub
ndrluis commented on PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#issuecomment-2318154885 @Fokko, I can solve the missing import. Do you mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-12 Thread via GitHub
Fokko commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1713463465 ## pyiceberg/io/fsspec.py: ## @@ -158,6 +160,14 @@ def _gs(properties: Properties) -> AbstractFileSystem: # https://gcsfs.readthedocs.io/en/latest/api.html#gc

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-09 Thread via GitHub
ndrluis commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1711967438 ## pyiceberg/io/pyarrow.py: ## @@ -388,7 +389,14 @@ def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) -> FileSyste gcs_kwargs

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-09 Thread via GitHub
ndrluis commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1711967825 ## pyiceberg/io/fsspec.py: ## @@ -76,6 +77,7 @@ OutputStream, ) from pyiceberg.typedef import Properties +from pyiceberg.utils.deprecated import deprecate

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-09 Thread via GitHub
ndrluis commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1711966599 ## pyiceberg/io/fsspec.py: ## @@ -158,6 +160,14 @@ def _gs(properties: Properties) -> AbstractFileSystem: # https://gcsfs.readthedocs.io/en/latest/api.html#

Re: [PR] Rename `gcs.endpoint` to `gcs.service.host` [iceberg-python]

2024-08-09 Thread via GitHub
ndrluis commented on code in PR #1007: URL: https://github.com/apache/iceberg-python/pull/1007#discussion_r1711963854 ## pyiceberg/io/fsspec.py: ## @@ -158,6 +160,14 @@ def _gs(properties: Properties) -> AbstractFileSystem: # https://gcsfs.readthedocs.io/en/latest/api.html#