kevinjqliu commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2494156220
LGTM! thanks for getting to the bottom of the numpy issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kevinjqliu merged PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
bigluck commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2492493406
Ok, I know what's going on.
```bash
$ make install
Poetry is already installed.
poetry install --all-extras
Installing dependencies from lock file
...
kevinjqliu commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491831803
possibly, you can test locally
```
make install
make test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
bigluck commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491823582
That's an interesting problem.
I don't know if by adding something like this can help
```python
numpy = { version = "<2.0.0", optional = true }
```
--
This is an a
kevinjqliu commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491814340
ugh looks like theres an issue with the numpy versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kevinjqliu commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491728091
I think that's fine, this is the current `numpy` version in the lock file.
https://github.com/apache/iceberg-python/blob/7a83695330518bea0dee589b5b513297c4d59b66/poetry.lock#
bigluck commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491730404
@kevinjqliu thanks, pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bigluck commented on PR #1355:
URL: https://github.com/apache/iceberg-python/pull/1355#issuecomment-2491718774
@kevinjqliu it failed because I forgot to update the poetry.lock file.
I did it locally, by using `poetry lock --no-update`, and I got this diff.
It's weird because it's addi
