Fokko merged PR #117:
URL: https://github.com/apache/iceberg-python/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #117:
URL: https://github.com/apache/iceberg-python/pull/117#issuecomment-1792690494
Thanks @bitsondatadev and @amogh-jahagirdar for the review 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Fokko commented on code in PR #117:
URL: https://github.com/apache/iceberg-python/pull/117#discussion_r1381820634
##
pyiceberg/io/pyarrow.py:
##
@@ -435,13 +435,18 @@ def delete(self, location: Union[str, InputFile,
OutputFile]) -> None:
raise # pragma: no cover -
Fokko commented on code in PR #117:
URL: https://github.com/apache/iceberg-python/pull/117#discussion_r1381820029
##
tests/io/test_pyarrow.py:
##
@@ -708,15 +709,17 @@ def _write_table_to_file(filepath: str, schema:
pa.Schema, table: pa.Table) -> s
@pytest.fixture
def file_
bitsondatadev commented on code in PR #117:
URL: https://github.com/apache/iceberg-python/pull/117#discussion_r1380591348
##
tests/io/test_pyarrow.py:
##
@@ -708,15 +709,17 @@ def _write_table_to_file(filepath: str, schema:
pa.Schema, table: pa.Table) -> s
@pytest.fixture
d
