Re: [PR] Pass in the type as a string [iceberg-python]

sunxiaojian commented on PR #1860: URL: https://github.com/apache/iceberg-python/pull/1860#issuecomment-2764609478 @kevinjqliu Fixed all the comments. PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Pass in the type as a string [iceberg-python]

kevinjqliu commented on code in PR #1860: URL: https://github.com/apache/iceberg-python/pull/1860#discussion_r2019955353 ## tests/test_types.py: ## @@ -231,6 +246,27 @@ def test_nested_field() -> None: assert "validation errors for NestedField" in str(exc_info.value) +d

Re: [PR] Pass in the type as a string [iceberg-python]

sunxiaojian commented on PR #1860: URL: https://github.com/apache/iceberg-python/pull/1860#issuecomment-2763764233 @kevinjqliu Thanks for the review! I've fixed all the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Pass in the type as a string [iceberg-python]

kevinjqliu commented on code in PR #1860: URL: https://github.com/apache/iceberg-python/pull/1860#discussion_r2019120254 ## tests/test_types.py: ## @@ -231,6 +231,22 @@ def test_nested_field() -> None: assert "validation errors for NestedField" in str(exc_info.value) +d