Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on PR #245: URL: https://github.com/apache/iceberg-python/pull/245#issuecomment-1969159803 Thanks @amogh-jahagirdar for working on this, and sorry for the long wait for the review. Thanks @HonahX for the review 🙌 -- This is an automated message from the Apache Git Service

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1506096650 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, ) ],

Re: [PR] Partition Evolution [iceberg-python]

Fokko merged PR #245: URL: https://github.com/apache/iceberg-python/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1506085599 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1504865802 ## pyiceberg/table/__init__.py: ## @@ -871,6 +924,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1502013528 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, )

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1502013528 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, )

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1498475605 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, ) ],

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1498366320 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, ) ],

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1498337498 ## pyiceberg/table/metadata.py: ## @@ -308,7 +308,8 @@ def construct_partition_specs(cls, data: Dict[str, Any]) -> Dict[str, Any]: data[PARTITION_S

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1498333203 ## pyiceberg/table/__init__.py: ## @@ -871,6 +924,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of this table."""

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479272548 ## pyiceberg/table/__init__.py: ## @@ -871,6 +924,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479272548 ## pyiceberg/table/__init__.py: ## @@ -871,6 +924,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479267152 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,423 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479267152 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,423 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479266072 ## tests/catalog/test_hive.py: ## @@ -277,7 +277,7 @@ def test_create_table(table_schema_simple: Schema, hive_database: HiveDatabase, )

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479265846 ## pyiceberg/table/metadata.py: ## @@ -308,7 +308,8 @@ def construct_partition_specs(cls, data: Dict[str, Any]) -> Dict[str, Any]: data[

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1479262998 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477705066 ## pyiceberg/table/__init__.py: ## @@ -868,6 +919,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477706261 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477705066 ## pyiceberg/table/__init__.py: ## @@ -868,6 +919,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477693599 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,423 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477690350 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base_metadata.

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477690350 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base_metadata.

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1477690350 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base_metadata.

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1476195413 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2331,242 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1476173833 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2331,242 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475572593 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475572378 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,240 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475571056 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,397 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475571056 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,397 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475567295 ## pyiceberg/table/__init__.py: ## @@ -868,6 +919,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475565719 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475565567 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2331,241 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475530412 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1473278876 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,240 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1471453813 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,243 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

HonahX commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1469034571 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base_metadata.

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1468131844 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1468130973 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,240 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1468130973 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,240 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1465805383 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on PR #245: URL: https://github.com/apache/iceberg-python/pull/245#issuecomment-1909916014 @amogh-jahagirdar Great work! 🙌 Most of them are nits. Thanks for adding the tests, I think we're close! -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466194396 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466193848 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466192240 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466189219 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466182935 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466180874 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466180874 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466173479 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466167206 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466165906 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466165281 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec: +_table

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466152450 ## pyiceberg/table/__init__.py: ## @@ -533,6 +543,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base_metadata.m

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466151531 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466149551 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466148835 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466147869 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466146144 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466144510 ## pyiceberg/partitioning.py: ## @@ -215,3 +235,111 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466143673 ## pyiceberg/partitioning.py: ## @@ -85,6 +91,20 @@ def __str__(self) -> str: """Return the string representation of the PartitionField class.""" r

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1466140863 ## pyiceberg/partitioning.py: ## @@ -85,6 +91,20 @@ def __str__(self) -> str: """Return the string representation of the PartitionField class.""" r

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1465798502 ## pyiceberg/partitioning.py: ## @@ -85,6 +91,20 @@ def __str__(self) -> str: """Return the string representation of the PartitionField class."""

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441727718 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441725509 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441724507 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441723506 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441716417 ## pyiceberg/partitioning.py: ## @@ -215,3 +230,118 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1438454615 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else sna

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1438454375 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else sna

Re: [PR] Partition Evolution [iceberg-python]

amogh-jahagirdar commented on PR #245: URL: https://github.com/apache/iceberg-python/pull/245#issuecomment-1872255962 There's still a lot of cleanup required, and need to add unit tests, also some bugs I'm encountering. But I'm putting up this draft since the core pieces are here. -- Thi