Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

kevinjqliu commented on PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#issuecomment-2584095157 Thanks for following up on this @smaheshwar-pltr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

kevinjqliu merged PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1911204940 ## mkdocs/docs/api.md: ## @@ -1077,6 +1077,7 @@ with table.update_schema() as update: with table.update_schema() as update: update.add_column(("det

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1911187965 ## tests/integration/test_partitioning_key.py: ## @@ -823,11 +789,6 @@ def test_partition_key( snapshot.manifests(iceberg_table.io)[0].fetc

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

kevinjqliu commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1911101051 ## tests/integration/test_partitioning_key.py: ## @@ -823,11 +789,6 @@ def test_partition_key( snapshot.manifests(iceberg_table.io)[0].fetch_man

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1909541302 ## tests/integration/test_partitioning_key.py: ## @@ -823,11 +789,6 @@ def test_partition_key( snapshot.manifests(iceberg_table.io)[0].fetc

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1909541206 ## tests/integration/test_partitioning_key.py: ## @@ -823,11 +789,6 @@ def test_partition_key( snapshot.manifests(iceberg_table.io)[0].fetc

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

kevinjqliu commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1907602687 ## pyiceberg/partitioning.py: ## @@ -237,8 +237,7 @@ def partition_to_path(self, data: Record, schema: Schema) -> str: value_str = quote_plus(va

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1907586150 ## pyiceberg/partitioning.py: ## @@ -237,8 +237,7 @@ def partition_to_path(self, data: Record, schema: Schema) -> str: value_str = quote_pl

Re: [PR] Nit fixes to URL-encoding of partition field names [iceberg-python]

smaheshwar-pltr commented on code in PR #1499: URL: https://github.com/apache/iceberg-python/pull/1499#discussion_r1907586459 ## tests/integration/test_partitioning_key.py: ## @@ -18,15 +18,15 @@ import uuid from datetime import date, datetime, timedelta, timezone from decima