Fokko commented on PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#issuecomment-2036374729
Thanks for working on this @syun64 and @HonahX for the review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Fokko merged PR #571:
URL: https://github.com/apache/iceberg-python/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#issuecomment-2036373338
The methods on the table were added as shorthands indeed. I'm open to
removing those methods and letting everything go through a transaction. This
way we have a single way to do things
syun64 commented on code in PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#discussion_r1550573900
##
tests/integration/test_writes.py:
##
@@ -778,3 +778,31 @@ def test_inspect_snapshots(
continue
assert left == right, f"Difference
jqin61 commented on code in PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#discussion_r1550202992
##
tests/integration/test_writes.py:
##
@@ -778,3 +778,31 @@ def test_inspect_snapshots(
continue
assert left == right, f"Difference
