Re: [PR] Minor fixes, #523 followup [iceberg-python]

2024-03-30 Thread via GitHub
HonahX commented on PR #563: URL: https://github.com/apache/iceberg-python/pull/563#issuecomment-2028534976 OOPs, I forgot that the same pattern also exists in [`table.overwrite()`](https://github.com/apache/iceberg-python/pull/563/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef3

Re: [PR] Minor fixes, #523 followup [iceberg-python]

2024-03-30 Thread via GitHub
HonahX merged PR #563: URL: https://github.com/apache/iceberg-python/pull/563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Minor fixes, #523 followup [iceberg-python]

2024-03-30 Thread via GitHub
kevinjqliu commented on PR #563: URL: https://github.com/apache/iceberg-python/pull/563#issuecomment-2028530382 oops looks like you already had a PR. I just removed all the prints -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Minor fixes, #523 followup [iceberg-python]

2024-03-30 Thread via GitHub
HonahX commented on PR #563: URL: https://github.com/apache/iceberg-python/pull/563#issuecomment-2028529240 @kevinjqliu Thanks for fixing this. Do you mind cleaning up the other 2 "prints" in `test_reads.py` and `test_writes.py` too? (#562 ) -- This is an automated message from the Apache